From ebe7dc86544409ef78ecd3595b4e2f245642089e Mon Sep 17 00:00:00 2001 From: Matthew Bourque Date: Thu, 30 Aug 2018 15:27:59 -0400 Subject: [PATCH 1/2] Added config file for pep8speaks --- .pep8speaks.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .pep8speaks.yml diff --git a/.pep8speaks.yml b/.pep8speaks.yml new file mode 100644 index 000000000..046ee63a7 --- /dev/null +++ b/.pep8speaks.yml @@ -0,0 +1,23 @@ +# File : .pep8speaks.yml + +message: # Customize the comment made by the bot + opened: # Messages when a new PR is submitted + header: "Hello @{name}, Thank you for submitting the Pull Request !" + # The keyword {name} is converted into the author's username + footer: "If you have not done so, please consult the [`jwql` Style Guide](https://github.com/spacetelescope/jwql/blob/master/style_guide/style_guide.md)" + # The messages can be written as they would over GitHub + updated: # Messages when new commits are added to the PR + header: "Hello @{name}, Thank you for updating !" + footer: "" # Why to comment the link to the style guide everytime? :) + no_errors: "Cheers ! There are no PEP8 issues in this Pull Request. :beers: " + +scanner: + diff_only: False # If True, errors caused by only the patch are shown + +pycodestyle: + max-line-length: 200 # Default is 79 in PEP8 + ignore: # Errors and warnings to ignore + - W391 + +only_mention_files_with_errors: True # If False, a separate status comment for each file is made. +descending_issues_order: False # If True, PEP8 issues in message will be displayed in descending order of line numbers in the file \ No newline at end of file From db7474b93f7333b157fe3c927342c110491e875a Mon Sep 17 00:00:00 2001 From: Matthew Bourque Date: Sat, 8 Sep 2018 10:02:37 -0400 Subject: [PATCH 2/2] Reduced max line length to 100. Removed W391 in ignore list. --- .pep8speaks.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.pep8speaks.yml b/.pep8speaks.yml index 046ee63a7..6127c00bb 100644 --- a/.pep8speaks.yml +++ b/.pep8speaks.yml @@ -15,9 +15,8 @@ scanner: diff_only: False # If True, errors caused by only the patch are shown pycodestyle: - max-line-length: 200 # Default is 79 in PEP8 + max-line-length: 100 # Default is 79 in PEP8 ignore: # Errors and warnings to ignore - - W391 only_mention_files_with_errors: True # If False, a separate status comment for each file is made. -descending_issues_order: False # If True, PEP8 issues in message will be displayed in descending order of line numbers in the file \ No newline at end of file +descending_issues_order: False # If True, PEP8 issues in message will be displayed in descending order of line numbers in the file