Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Have a way for some subsets to only be shown in some viewers #2325

Open
eteq opened this issue Jul 31, 2023 · 3 comments
Open

[FEAT] Have a way for some subsets to only be shown in some viewers #2325

eteq opened this issue Jul 31, 2023 · 3 comments
Labels
feature Feature request imviz

Comments

@eteq
Copy link
Contributor

eteq commented Jul 31, 2023

Jdaviz component

Imviz

What is the problem this feature will solve?

The current behavior when multiple viewers are present and you select a subregion seems to be for the selection to propogate to all the viewers. That's good in some cases, but there are other situation where a subset is really only relevant for one of the viewers but not others.

Describe the desired outcome

It would be good if there was a way to quickly and easily specify "this subset should only be shown on the viewer I'm clicking on". I get that subsets as a data structure are not tied definitively to the viewer, but from a UI perspective, a toggle to turn on or off the show-in-all-viewers behavior on a per-subset basis would be good. Maybe just a toggle in the subset-creation UI?

Additional context

🐱

@eteq eteq added feature Feature request needs-triage Issue opened via template and needs triaging labels Jul 31, 2023
@kecnry
Copy link
Member

kecnry commented Jul 31, 2023

toggling the display of the subset per-viewer is currently supported in plot options. If its a common workflow, then maybe we would want to expose it in a more convenient way, but if its not common, I think this should do the trick?

@pllim pllim added imviz and removed needs-triage Issue opened via template and needs triaging labels Aug 1, 2023
@pllim
Copy link
Contributor

pllim commented Aug 1, 2023

@kecnry , can we do the same thing with markers? Just in case if we ever go with #2238

@kecnry
Copy link
Member

kecnry commented Aug 1, 2023

Probably, but not directly out-of-the-box.

I think both the astrowidgets and plugin implementation of markers are at the bqplot-level, whereas the plot options plugin acts on glue layer states. But there's nothing stopping us from extending plot options to also expose some options on the bqplot marks objects (or possibly looking into having them as official glue layers while still avoiding putting them in the data-collection, if necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request imviz
Projects
None yet
Development

No branches or pull requests

3 participants