Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI upgrade #57

Open
jaymedina opened this issue Mar 17, 2022 · 2 comments
Open

CI upgrade #57

jaymedina opened this issue Mar 17, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jaymedina
Copy link
Collaborator

jaymedina commented Mar 17, 2022

Following the work on PR #56

@falkben has a couple suggestions on how the GitHub Actions workflow can be improved for astrocut:

  • cutting out 3.6
  • including 3.9 and 3.10
  • updating the other dependencies we test against (e.g. which version of astropy and numpy)
  • cleaning up the tox.ini file for anything we're not using, which i'm not even sure what we're not using at this point and what we are using.
  • seeing why "Python 3.7 with dev version of key dependencies" ALWAYS fails (i know we mark is allowed failure... but if it always fails, it's not useful either)
  • fixing python 3.8 windows 32 test
@jaymedina jaymedina added the enhancement New feature or request label Mar 17, 2022
@jaymedina jaymedina self-assigned this Mar 17, 2022
@pllim
Copy link
Contributor

pllim commented Mar 17, 2022

astropy 5.x has dropped Python 3.7. So if you are trying to install astropy dev in Python 3.7, it is going to always fail. I recommend you bump dev job to Python 3.10.

@ceb8
Copy link
Collaborator

ceb8 commented Mar 18, 2022

@pllim That makes sense, it was around when 5.0 came out that that failure started, I just never got the time to figure out why it was breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants