-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail with dev astropy #47
Comments
This bug has been temporarily patched by simply not using the affected astropy function for the versions of astropy where it causes problems. This is not a long term solution. The bug is a result of the changes to the astropy For sure the pixel shape calculation here https://github.com/astropy/astropy/pull/10865/files#diff-e6ff41e178a73eba0e29f8d018f2bc610617f18d9e653b75e2250017fcab34fcR1066 is incorrect. We cannot assume the minimum pixel value is zero, and it could be less than zero. The trickier part is the +1 correction for FITS versus numpy arrays. This will require more exploration to determine if it is being treated correctly. It's possible it is being corrected at the wrong juncture, or double corrected, or our code could be wrong. An example that causes the failure is as follows (I'm sure a more minimal example can be created, sorry about that):
|
The Python 3.7 with dev astropy tests are failing, this needs to be fixed before the next astropy release.
The text was updated successfully, but these errors were encountered: