Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor errata #16

Open
2 of 9 tasks
ceb8 opened this issue Aug 9, 2019 · 0 comments
Open
2 of 9 tasks

Minor errata #16

ceb8 opened this issue Aug 9, 2019 · 0 comments
Labels
bug Something isn't working Priority: Medium Needs to be implemented, but not immediately

Comments

@ceb8
Copy link
Collaborator

ceb8 commented Aug 9, 2019 •
edited
Loading

Issue to capture small non-urgent things that I notice while adding new functionality:

cube_cut.py

  • _get_cutout_limits docstring parameters is wrong (center_coord is no longer a param)

  • target_pixel_file = os.path.join(output_path, tpf_name) is indented one too far

  • Get rid of the overwrite=True or make it an argument in cube_cut?

  • Make cube_cut handle x vs y consistent with new fits_cut functionality (which is correct)

  • Update file creation date to reflect cutout date not cube date

Tests

  • Remove unused extname argument in add_keywords

General

  • Make a utils file and move common functionality there
  • Update docs to include info on how to cite
  • Refactor cube_cut/make_cube into one file?
@ceb8 ceb8 added bug Something isn't working Priority: Medium Needs to be implemented, but not immediately labels Aug 9, 2019
@ceb8 ceb8 mentioned this issue Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Priority: Medium Needs to be implemented, but not immediately
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ceb8