Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator says to "check the details below" for invalid JSON, but there are no details #1

Open
Xiretza opened this issue Aug 15, 2022 · 1 comment

Comments

@Xiretza
Copy link

Xiretza commented Aug 15, 2022

For e.g. the following JSON, which is missing the issue_report_channels key:

{
  "api":"0.13",
  "api_compatibility":["14"],
  "space":"IT-Syndikat",
  "logo":"https://it-syndikat.org/api/images/its_l.png",
  "url":"https://it-syndikat.org",
  "location":{
    "address":"Tschamlerstrasse 3, 6020 Innsbruck, Austria",
    "lat":47.2578,
    "lon":11.3961
  },
  "state":{
    "open":false,
    "lastchange":1660506330,
    "icon":{
      "open":"https://it-syndikat.org/api/images/ITS_Open.png",
      "closed":"https://it-syndikat.org/api/images/ITS_Closed.png"
    }
  },
  "contact":{
    "phone":"+43 512 563468",
    "mastodon":"@[email protected]",
    "twitter":"@ItSyndikat",
    "email":"[email protected]",
    "matrix":"#lobby:it-syndik.at"
  },
  "membership_plans":[
    {
      "name": "Normal membership",
      "value": 20,
      "currency": "EUR",
      "billing_interval": "monthly"
    },
    {
      "name": "Student membership",
      "value": 10,
      "currency": "EUR",
      "billing_interval": "monthly"
    }
  ],
  "ext_ccc": "chaostreff"
}

https://validator.spaceapi.io/ui/ reports:

Checked JSON is invalid!
The checked JSON is not valid against the SpaceAPI schema, check the details below.

But there are no details that mention issue_report_channels in any way.

@dbrgn
Copy link

dbrgn commented Apr 11, 2024

Hmm, seems I wasn't subscribed to notifications on this repo.

Bug confirmed. The API returns the correct value, so it's the web UI that doesn't properly handle it.

screenshot-2024-04-12T00:31:36+02:00

I suspect the current UI would highlight the problematic key, but because the key is missing completely, there is nothing to highlight.

(If someone wants to take a closer look and open a PR, that would be welcome.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants