Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pooling implementation is lacking #12

Open
metalgearsloth opened this issue Nov 20, 2023 · 0 comments
Open

The pooling implementation is lacking #12

metalgearsloth opened this issue Nov 20, 2023 · 0 comments

Comments

@metalgearsloth
Copy link

Okay so I did some digging around and noticed some things:

  • NetBuffer / NetMessage have recycling and the data is dumped back into a pool, however the default size is tiny and it continuously re-allocates. This is probably better off just using its own created ArrayPool instead which would dramatically reduce the heap allocations for Lidgren for us.

  • Delayed packets allocates a lot and should also be using GetStorage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant