Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parity with C#] BotAdapter UpdateActivity method signature #54

Open
gasper-az opened this issue Jul 2, 2019 · 0 comments
Open

[Parity with C#] BotAdapter UpdateActivity method signature #54

gasper-az opened this issue Jul 2, 2019 · 0 comments

Comments

@gasper-az
Copy link

gasper-az commented Jul 2, 2019

Is your feature request related to a problem? Please describe.
We've found some differences between the updateActivity method from BotAdapter in DotNet and JS SDK.

In the DotNet version (link here), the UpdateActivityAsync method returns a Task<ResourceResponce>, which allows us to access to the ResourceResponse properties, as its Id. However, in the JS version (link here), the method returns a Promise, which is a completely different behavior from the DotNet's implementation.

Describe the solution you'd like
Add a new implementation of the updateActivity in BotAdapter.ts which returns a Promise<ResourceResponse> for ensuring parity with the DotNet version.

Additional context
DotNet implementation:
image

JS implementation:
image

[enhancement]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant