Malformed apt repository

[NotJustPizza]

🗣️ Foreword

Installation fails due to malformed mariadb_org_repository.list. Apt works again if I remove it. This issue is something recent, it was working with similar setup a week ago.

🥞 Cookbook version

3.1.0

👩‍🍳 Chef-Infra Version

Chef Server: 13.0.17
Chef Client: 15.0.300

🎩 Platform details

Debian 10.1.0 amd64 netinst

Steps To Reproduce

Add it to your cookbook and run chef-client:

mariadb_server_install 'MariaDB Server' do
  version "10.4"

  setup_repo true
end

🚓 Expected behavior

Valid apt entry like deb http://mariadb.mirrors.ovh.net/MariaDB/repo/10.4/debian buster main instead of deb "http://mariadb.mirrors.ovh.net/MariaDB/repo/10.4/debian" main

➕ Additional context

Log fragment:

(chef):           * file[/etc/apt/sources.list.d/mariadb_org_repository.list] action create
(chef):             - create new file /etc/apt/sources.list.d/mariadb_org_repository.list
(chef):             - update content in file /etc/apt/sources.list.d/mariadb_org_repository.list from none to 7b8fb0
(chef):             --- /etc/apt/sources.list.d/mariadb_org_repository.list      2019-10-31 20:30:22.004977974 +0000
(chef):             +++ /etc/apt/sources.list.d/.chef-mariadb_org_repository20191031-3962-1venmz4.list   2019-10-31 20:30:22.000978042 +0000
(chef):             @@ -1 +1,2 @@
(chef):             +deb      "http://mariadb.mirrors.ovh.net/MariaDB/repo/10.4/debian" main
(chef):           * execute[apt-cache gencaches] action run[2019-10-31T20:30:22+00:00] ERROR: xecute[apt-cache gencaches] (/opt/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.0.300/lib/chef/provider/apt_repository.rb line 51) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '100'
(chef): ---- Begin output of ["apt-cache", "gencaches"] ----
(chef): STDOUT:
(chef): STDERR: E: Malformed entry 1 in list file /etc/apt/sources.list.d/mariadb_org_repository.list (Component)
(chef): E: The list of sources could not be read.
(chef): ---- End output of ["apt-cache", "gencaches"] ----

[ccrebolder]

I'm having trouble reproducing this. Is the node['lsb']['codename'] attribute populated on your system? That is where the value comes from https://github.com/sous-chefs/mariadb/blob/v3.1.0/resources/repository.rb#L60