-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider using sourmash core ComputeParameters
instead of BuildParams
#113
Comments
- refactor for reusability: move all generalized sketch building utils --> `utils/buildutils.rs` - do minor refactoring to use `sourmash::encodings::HashFunctions` for `moltype`, created `Abund` enum. - requires sourmash-bio/sourmash#3344 to use `Hash` for `sourmash::encodings::HashFunctions` Related: - #113
Actually, I think the main barrier right now is the sig filtering strategy. Currently, we store a hashed version of the Change potential strategy:
|
This is in progress in #127 |
With #112,
BuildParams
gets closer tosourmash::cmd::ComputeParameters
.Differences:
ComputeParameters
have multiple ksizes, which makes them non 1:1 with records.BuildParams
uses theHashFunctions
enum when reading in a command line parameter string. Not necessary, but kinda nice.The text was updated successfully, but these errors were encountered: