Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examine rocksdb fastmultigather performance degradation #472

Closed
ctb opened this issue Oct 13, 2024 · 1 comment
Closed

examine rocksdb fastmultigather performance degradation #472

ctb opened this issue Oct 13, 2024 · 1 comment

Comments

@ctb
Copy link
Collaborator

ctb commented Oct 13, 2024

in #471, we see a ~10% degradation in the performance of RocksDB-based gather. I'm wondering how much of this is due to sourmash-bio/sourmash#3342, and specifically the redundant downsampling we are now doing?

The degradation is only 10%, and the code cleanup and memory improvements are worth it. Just wanted to drop this in as something to investigate, while my head is in the code.
@ctb
Copy link
Collaborator Author

ctb commented Oct 16, 2024

Fixed by sourmash-bio/sourmash#3352

@ctb ctb closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb