Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust ZipStorage::from_file to pass errors up on bad zip file #3398

Open
ctb opened this issue Nov 14, 2024 · 0 comments
Open

adjust ZipStorage::from_file to pass errors up on bad zip file #3398

ctb opened this issue Nov 14, 2024 · 0 comments

Comments

@ctb
Copy link
Contributor

ctb commented Nov 14, 2024

This line:

                piz::ZipArchive::new(mapping.as_ref().unwrap()).unwrap()

in storage/mod.rs causes panics that would be better handled by the calling function, I think. Or at least it would be nice to have the option :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant