Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Context: handle qualified symbol names #61974

Closed
jtibshirani opened this issue Apr 17, 2024 · 1 comment
Closed

Context: handle qualified symbol names #61974

jtibshirani opened this issue Apr 17, 2024 · 1 comment
Assignees
@stefanhengl
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. team/search-platform Issues owned by the search platform team

Comments

@jtibshirani
Copy link
Member

jtibshirani commented Apr 17, 2024 •
edited by sourcegraph-bot-2
Loading

Currently, if your search has a qualified symbol name like indexData.scoreFile or grf::causal_forest, we can fail to find results. This is likely because we only tokenize on whitespace.

Here's an example using patterntype:codycontext that returns no results, when it should find relevant snippets.

Original Slack thread

Relates to #61571

/cc @sourcegraph/search-platform
@jtibshirani jtibshirani added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. team/search-platform Issues owned by the search platform team labels Apr 17, 2024
@jtibshirani
Copy link
Member Author

Loosely related: https://github.com/sourcegraph/sourcegraph/issues/53087

@stefanhengl stefanhengl self-assigned this Apr 22, 2024
@stefanhengl stefanhengl mentioned this issue Apr 24, 2024
Merged
stefanhengl added a commit that referenced this issue Apr 25, 2024
@stefanhengl
context: handle qualified symbol names (#62142)
7d80a58 
Relates to #61974

With this change we split patterns on common namespace separators like "::", ".", or "->"

Test plan:
updated unit tests
manual testing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stefanhengl stefanhengl

Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. team/search-platform Issues owned by the search platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtibshirani @stefanhengl