Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Search: fold unindexed search into Zoekt #60442

Open
jtibshirani opened this issue Feb 12, 2024 · 1 comment
Open

Search: fold unindexed search into Zoekt #60442

jtibshirani opened this issue Feb 12, 2024 · 1 comment
Labels
team/search-platform Issues owned by the search platform team

Comments

@jtibshirani
Copy link
Member

jtibshirani commented Feb 12, 2024

It could be really nice if Zoekt handled unindexed search instead of our separate 'searcher' service. Some benefits:

  • Unindexed searches would benefit from Zoekt's ranking
  • We wouldn't to have to implement new search features in multiple places
  • It'd simplify our "hybrid search" implementation (and make it more efficient?)

This feels like a large and fairly tricky project, since Zoekt is not factored in such a way that makes it easy to load and parse content on the fly. But it'd save us time in the longer term, as we'd no longer need to implement search features in two separate places. Some recent examples of this extra work:

/cc @sourcegraph/search-platform

@jtibshirani jtibshirani added the team/search-platform Issues owned by the search platform team label Feb 12, 2024
@keegancsmith
Copy link
Member

Not sure how useful it is, but I got started on factoring out the matchtree abstraction into a public API like 6 years ago :) I think my plan then was to use it inside of searcher so we could support and/or queries efficiently, but at the time we decided against it at the time so I reverted those changes. https://github.com/sourcegraph/zoekt/blob/dacbbfd8c3ceab2bb3288d28ce3f35d3a3eb3c13/matchtree/matchtree.go

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team/search-platform Issues owned by the search platform team
Projects
None yet
Development

No branches or pull requests

4 participants