Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect hostname in commit link when using inline git blame functionality #85

Open
zhuli19901106 opened this issue Oct 29, 2019 · 2 comments

Comments

@zhuli19901106
Copy link

zhuli19901106 commented Oct 29, 2019

Hi, I'm a software engineer from 4Paradigm, also a user of Sourcegraph.

I appreciate your wonderful product very much, which really helps me with code analysis.

I'd like to report a minor bug here.

As specified in the title, the URL always points to 127.0.0.1, while it's supposed to be the same hostname where it's deployed.

Setup info:

  • OS: Linux 4.4.166-1.el7.elrepo.x86_64 Configure Renovate #1 SMP Sat Dec 1 10:48:24 EST 2018 x86_64 x86_64 x86_64 GNU/Linux
  • Installed via Docker image, tag=sourcegraph/server:3.8.2.
  • Private deployment on my own development server.
  • Use plugin, git-extras.

Inline commit message is correct, but generated URL points to 127.0.0.1:7080 instead of xxx (the host where I deployed it).

@Fazich
Copy link

Fazich commented Nov 27, 2019

I have the same problem

@zhuli19901106
Copy link
Author

Well, I've spent 5 minutes to check the code and found this:
image

Since I ran Sourcegraph from within docker, no wonder the hostname is 127.0.0.1.

I've never written typescript though, maybe I'll put in a fix later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants