Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRD: [Cody Ignore] Enterprise users cannot use ignored repos as context for Commands #1209

Closed
2 tasks
aramaraju opened this issue Mar 28, 2024 · 5 comments
Closed
2 tasks

Comments

@aramaraju
Copy link
Contributor

aramaraju commented Mar 28, 2024

Description:

When an enterprise admin has configured Cody to allow/ignore repos, Cody commands, both built-in and custom, must not be available to the user

As a user on an enterprise instance that has Cody allow/ignore repos configured...
P0: I cannot run any Cody commands, both built-in and custom, on any excluded code
P1: I am able to understand that I cannot use commands because the code has been excluded by my administrator
P2: I see guidance in the UX for how to request that my admin include an excluded repo

Objectives:

Cody does not send any code from excluded repos to the LLM when a user is using Cody's commands feature.

Acceptance Criteria:

  • When the user selects content in an excluded file and attempts to perform a built-in command operation using the right-click menu, they should not be able to complete the operation
  • When the user selects content in an excluded file and attempts to perform a built-in command using the in-line menu, they should not be able to complete the operation
  • An appropriate notification is provided saying that these operations cannot be completed because the repo is excluded

Design Tasks:

Design Tasks

Engineering Tasks:

Engineering Tasks

Related Docs:

Cody Ignore and Cody Allow GA PRD
RFC 910: Cody Ignore GA Implementation

@aramaraju
Copy link
Contributor Author

@taylorsperry Could use some help here as I am not completely clear on the different ways commands can be triggered on JBs?

Additionally, I think it should be an UX decision on whether the operation should be disabled or the operation should run and have an error saying it cannot be completed. I'm fine with either interaction personally (the latter is easier for me)

@dominiccooney
Copy link
Contributor

dominiccooney commented Mar 28, 2024

@aramaraju let's break this up by Edit, Document, Generate Unit Test, Ask Cody to Fix, and Custom Commands because we need to track all of those in detail. (Note, no Custom Commands in JetBrains yet.)

I am not completely clear on the different ways commands can be triggered on JBs?

One of four ways:

Through a context menu:

Screenshot 2024-03-28 at 17 03 53

Sidebar menu:

Screenshot 2024-03-28 at 17 05 02

Keyboard shortcut

Or command palette:

Screenshot 2024-03-28 at 17 06 34

Additionally, I think it should be an UX decision on whether the operation should be disabled or the operation should run and have an error saying it cannot be completed.

+1. Part of why I wanted this issue broken down in detail is so I can map @toolmantim 's design guidance against each item, then go work out what that will take to build.

@dominiccooney
Copy link
Contributor

dominiccooney commented Apr 1, 2024

@aramaraju, @taylorsperry: We should polish this specific issue a bit.

@aramaraju
Copy link
Contributor Author

@dominiccooney - Yes, I created those additional broken down items for the built-in commands as requested. I'll let @kalanchan chime in on an 'uber' issue for bucketing everything if that helps.

For custom commands, I agree that if there is a ticket for custom commands (my understanding is that it is not in GA scope based on the PRD), we should add the behavior for Cody Ignore under that.

@kalanchan
Copy link
Contributor

closing this in favour of #1238 #1239 #1240 #1241 #1242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants