Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRD: [Cody Ignore] Enterprise users cannot use ignored repos as context for autocomplete #1208

Closed
2 of 6 tasks
aramaraju opened this issue Mar 28, 2024 · 5 comments
Closed
2 of 6 tasks

Comments

@aramaraju
Copy link
Contributor

aramaraju commented Mar 28, 2024

Description:

When an enterprise admin has configured Cody to allow/ignore repos:

  • Cody should not offer any autocomplete suggestions on any code from those repos
  • The code from those repos cannot be used as context for generating autocomplete suggestions in other files
  • Users need to have the appropriate visibility that autocomplete suggestions are turned off for such files

As a user on an enterprise instance that has Cody allow/ignore repos configured...
P0: I cannot use Cody's autocomplete on any of the code that has been excluded by my admin
P1: I am able to quickly discern when Cody autocomplete is not available when I am editing any excluded code
P2: I see guidance in the UX for how to request that my admin include an excluded repo

Objectives:

The user is not able to use Cody's autocomplete on any code from the excluded repos and content from these repos is not shared with the LLM

Acceptance Criteria:

  • Users cannot see any Cody autocomplete suggestions on any code that is excluded
  • User should not be able to perform autocomplete using the in-line autocomplete action, where the icon should be either disabled or the operation should fail with an error
  • User should not be able to perform autocomplete using any keyboard shortcuts
  • Code in any excluded repo cannot be used as context for autocomplete suggestions on other files
  • The UI informs the user that Cody autocomplete is not available through the IDE toolbar because they are working on an excluded file
  • P1: Any new or unsaved files created in the excluded repos must also honor the behavior mentioned above

Design Tasks:

Design Tasks

Engineering Tasks:

Engineering Tasks

  1. 20 of 20
    clients/jetbrains cody enterprise pfp-jetbrains-cody-ignore pfp-jetbrains-may pfp-vscode-cody-ignore
    valerybugakov
  2. clients/jetbrains pfp-jetbrains-cody-ignore pfp-jetbrains-may
    dominiccooney

Related Docs:

@aramaraju
Copy link
Contributor Author

@kalanchan @taylorsperry @dominiccooney would love your review on this. Please let me know if there are other questions that I could help answer

@dominiccooney
Copy link
Contributor

@aramaraju thanks, this is helpful. Not sure what the screenshot is communicating. IDEs have multiple autocomplete providers, so when Cody autocomplete is not enabled, those other providers will still appear.

@aramaraju
Copy link
Contributor Author

aramaraju commented Mar 29, 2024

The screenshot show the Cody Autocomplete option I added to the toolbar, but yes the other autcomplete providers shouldn't be affected. I removed the screenshot to avoid this confusion.

@dominiccooney
Copy link
Contributor

Reviewed the extension autocomplete code and believe, if we fix isCodyIgnoredFile, then autocomplete will be suppressed for ignored files. There's no "extra" work there.

@kalanchan
Copy link
Contributor

All complete as part of 6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants