From be6a96d6e8f479d906518adea1cb90b6da4f5176 Mon Sep 17 00:00:00 2001 From: Alex Jean-Baptiste Jr Date: Wed, 17 Jul 2024 14:27:30 -0400 Subject: [PATCH 1/3] Updating README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 37b69a33..55c41289 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,6 @@ Deploy Sourcegraph on Kubernetes using [Helm]. -Check the [Quickstart](https://docs.sourcegraph.com/admin/install/kubernetes/helm#quickstart) to deploy your Sourcegraph. +Check the [Quickstart](https://sourcegraph.com/docs/admin/deploy/kubernetes#quickstart) to deploy your Sourcegraph. [helm]: https://helm.sh From 0c019ea0bf85de13b76f7714ce5d1c7fa6654b59 Mon Sep 17 00:00:00 2001 From: Alex Jean-Baptiste Jr Date: Mon, 23 Sep 2024 17:40:00 -0400 Subject: [PATCH 2/3] Modified exector role for necessary cluster permissions --- .../k8s/templates/executor.Role.yaml | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/charts/sourcegraph-executor/k8s/templates/executor.Role.yaml b/charts/sourcegraph-executor/k8s/templates/executor.Role.yaml index c326092c..9da283c5 100644 --- a/charts/sourcegraph-executor/k8s/templates/executor.Role.yaml +++ b/charts/sourcegraph-executor/k8s/templates/executor.Role.yaml @@ -2,34 +2,22 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: Role metadata: - name: sg-executor-role + name: executor labels: - category: rbac deploy: sourcegraph - sourcegraph-resource-requires: cluster-admin app.kubernetes.io/component: executor rules: - - apiGroups: - - batch - resources: - - jobs - verbs: - - create - - delete - apiGroups: - "" resources: - pods - pods/log + - secrets + - persistentvolumeclaims verbs: - get - list - watch - - apiGroups: - - "" - resources: - - secrets - verbs: - create - delete {{- end }} From fbd05af923fad4836cd3fb15806b3667f5c78a84 Mon Sep 17 00:00:00 2001 From: Alex Jean-Baptiste Jr Date: Mon, 23 Sep 2024 17:51:16 -0400 Subject: [PATCH 3/3] Modifcation to keep previous metadata and naming --- charts/sourcegraph-executor/k8s/templates/executor.Role.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/charts/sourcegraph-executor/k8s/templates/executor.Role.yaml b/charts/sourcegraph-executor/k8s/templates/executor.Role.yaml index 9da283c5..d899be32 100644 --- a/charts/sourcegraph-executor/k8s/templates/executor.Role.yaml +++ b/charts/sourcegraph-executor/k8s/templates/executor.Role.yaml @@ -2,9 +2,11 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: Role metadata: - name: executor + name: sg-executor-role labels: + category: rbac deploy: sourcegraph + sourcegraph-resource-requires: cluster-admin app.kubernetes.io/component: executor rules: - apiGroups: