Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony 7.0 compatibility #23

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

JoshuaBehrens
Copy link
Contributor

This seems to be the only change needed to let it run under Symfony 7.0

Declaration of Sourceability\Instrumentation\Bundle\DependencyInjection\Configuration::getConfigTreeBuilder() must be compatible with Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder(): Symfony\Component\Config\Definition\Builder\TreeBuilder

I assume Symfony 7.0 needs to be added to the suggestions in the composer.json as well. Do you need it somewhere else as well? Maybe for testing?

@adrienbrault adrienbrault merged commit e33e7be into sourceability:main Apr 9, 2024
7 checks passed
@adrienbrault
Copy link
Collaborator

Thank you! Tagged 1.0.4

@JoshuaBehrens
Copy link
Contributor Author

Thank you for merging :)

@JoshuaBehrens JoshuaBehrens deleted the patch-1 branch April 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants