Remove manual rate limiting and fix GlobalTracer reset #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample rate is sent to the Datadog agent and is used even when manual profiling like this project does so the sampling logic in the
DataDogProfiler
is causing the sampling rate to be applied twice.In addition the Global tracer isn't being reset properly in
stopAndIgnore
which creates a single trace even when multiple traces are subsequently started and stopped.There are no traces on master. In the screenshot you can see 2 requests since I ran the command twice, but no spans were created.
There are 4 traces using this branch: