Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs should detect if WebGL is disabled #321

Open
yockcheng opened this issue Aug 26, 2024 · 5 comments
Open

Tabs should detect if WebGL is disabled #321

yockcheng opened this issue Aug 26, 2024 · 5 comments

Comments

@yockcheng
Copy link

Attempt to run code in playground for Studio 3 In-Class Studio Sheet causes website to crash.

Code Error
@RichDom2185
Copy link
Member

Not a bug. Please enable WebGL in the browser.

@RichDom2185 RichDom2185 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@martin-henz
Copy link
Member

But should the frontend crash? Any way to check if webgl is enabled?

@RichDom2185
Copy link
Member

But should the frontend crash? Any way to check if webgl is enabled?

I don't think it should be handled by frontend. Should be handled by modules, since that's what's causing the render to fail

@RichDom2185
Copy link
Member

i.e., the tab should render the error message

@martin-henz martin-henz transferred this issue from source-academy/frontend Aug 26, 2024
@martin-henz martin-henz reopened this Aug 26, 2024
@leeyi45 leeyi45 changed the title Attempt to run code in playground causes website to crash. Tabs should detect if WebGL is disabled Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@martin-henz @RichDom2185 @yockcheng and others