Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown DCX Format with latest patch #920

Open
sarkhav opened this issue Jun 20, 2024 · 12 comments
Open

Unknown DCX Format with latest patch #920

sarkhav opened this issue Jun 20, 2024 · 12 comments

Comments

@sarkhav
Copy link

sarkhav commented Jun 20, 2024

Unable to create a new project and modify regulation.bin as of 20/6/24 update

@Odashikonbu
Copy link

Odashikonbu commented Jun 20, 2024

Same issue. this is full crash log
`DSMapStudio Version 1.11.0

The value cannot be an empty string. (Parameter 'path')

   at System.ArgumentException.ThrowNullOrEmptyException(String, String)
   at System.ArgumentException.ThrowIfNullOrEmpty(String , String )
   at System.IO.File.WriteAllBytes(String, Byte[])
   at StudioCore.Editor.ProjectSettings.Serialize(String path) in ./src/StudioCore/Editor/ProjectSettings.cs:line 51
   at StudioCore.MapStudioNew.SaveAll() in ./src/StudioCore/MapStudioNew.cs:line 633
   at StudioCore.MapStudioNew.AttemptSaveOnCrash() in ./src/StudioCore/MapStudioNew.cs:line 666
   at DSMapStudio.Program.Main(String[]) in ./src/Studio.App/DSMapStudio/Program.cs:line 40`

@ScipiosDefence
Copy link

ScipiosDefence commented Jun 20, 2024

Same issue for me as well.

DSMapStudio Version 1.11.0

Unknown DCX format.

at SoulsFormats.DCX.Decompress(BinaryReaderEx br, Type& type) in ./src/Andre/SoulsFormats/SoulsFormats/Formats/DCX.cs:line 159
at SoulsFormats.SFUtil.GetDecompressedBR(BinaryReaderEx br, Type& compression) in ./src/Andre/SoulsFormats/SoulsFormats/Util/SFUtil.cs:line 212
at SoulsFormats.MountedSoulsFile1.Read(Memory1 bytes) in ./src/Andre/SoulsFormats/SoulsFormats/Util/MountedSoulsFile.cs:line 28
at SoulsFormats.SFUtil.DecryptERRegulation(String path) in ./src/Andre/SoulsFormats/SoulsFormats/Util/SFUtil.cs:line 531
at StudioCore.ParamEditor.ParamBank.LoadParamsERFromFile(String path, Boolean encrypted) in ./src/StudioCore/ParamEditor/ParamBank.cs:line 952
at StudioCore.ParamEditor.ParamBank.LoadParamsER(Boolean partial) in ./src/StudioCore/ParamEditor/ParamBank.cs:line 878
at StudioCore.ParamEditor.ParamBank.<>c__DisplayClass73_0.b__0() in ./src/StudioCore/ParamEditor/ParamBank.cs:line 1112
at StudioCore.Editor.TaskManager.LiveTask.b__15_0() in ./src/StudioCore/Editor/TaskManager.cs:line 183
at System.Threading.Tasks.Task.InnerInvoke()
at System.Threading.Tasks.Task.<>c.<.cctor>b__281_0(Object obj)
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object)
--- End of stack trace from previous location ---
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&, Thread )

Log 2024-6-20--11-12-27.txt

@Philiquaz
Copy link
Collaborator

Philiquaz commented Jun 20, 2024

Until an update supporting dlc+ is written, I recommend downpatching the game back to 1.10.1 if you intend to do any modding.
Your mod won't have been affected.

I will leave this issue open so others can find it.

@foxhound1220
Copy link

Will downpatching the game result in being unable to play the DLC?

@Philiquaz
Copy link
Collaborator

Will downpatching the game result in being unable to play the DLC?

You had no practical chance of playing the DLC modded so soon anyway.

@SILCO332
Copy link

I have the same issue, but also these error logs:

DSMapStudio Version 1.11.1

The value cannot be an empty string. (Parameter 'path')

   at System.ArgumentException.ThrowNullOrEmptyException(String, String)
   at System.ArgumentException.ThrowIfNullOrEmpty(String , String )
   at System.IO.File.WriteAllBytes(String, Byte[])
   at StudioCore.Editor.ProjectSettings.Serialize(String path) in ./src/StudioCore/Editor/ProjectSettings.cs:line 51
   at StudioCore.MapStudioNew.SaveAll() in ./src/StudioCore/MapStudioNew.cs:line 633
   at StudioCore.MapStudioNew.AttemptSaveOnCrash() in ./src/StudioCore/MapStudioNew.cs:line 666
   at DSMapStudio.Program.Main(String[]) in ./src/Studio.App/DSMapStudio/Program.cs:line 40

DSMapStudio Version 1.11.1

Object reference not set to an instance of an object.

   at StudioCore.SettingsMenu.DisplaySettings_MapEditor() in ./src/StudioCore/SettingsMenu.cs:line 257
   at StudioCore.SettingsMenu.Display() in ./src/StudioCore/SettingsMenu.cs:line 943
   at StudioCore.MapStudioNew.Update(Single deltaseconds) in ./src/StudioCore/MapStudioNew.cs:line 1018
   at StudioCore.MapStudioNew.Run() in ./src/StudioCore/MapStudioNew.cs:line 368
   at DSMapStudio.Program.Main(String[]) in ./src/Studio.App/DSMapStudio/Program.cs:line 36

But last time I had a startup crash:

DSMapStudio Version 1.11.1

The value cannot be an empty string. (Parameter 'path')

   at System.ArgumentException.ThrowNullOrEmptyException(String, String)
   at System.ArgumentException.ThrowIfNullOrEmpty(String , String )
   at System.IO.File.WriteAllBytes(String, Byte[])
   at StudioCore.Editor.ProjectSettings.Serialize(String path) in ./src/StudioCore/Editor/ProjectSettings.cs:line 51
   at StudioCore.MapStudioNew.SaveAll() in ./src/StudioCore/MapStudioNew.cs:line 633
   at StudioCore.MapStudioNew.AttemptSaveOnCrash() in ./src/StudioCore/MapStudioNew.cs:line 666
   at DSMapStudio.Program.Main(String[]) in ./src/Studio.App/DSMapStudio/Program.cs:line 40

@LaykaKiro
Copy link

Same issue when opening my project to update it.
Here's the errors.
2024-06-21 21_09_43-Dark Souls Map Studio version 1 11 1  -  Layka

@melak47
Copy link

melak47 commented Jun 22, 2024

The new compression type is ZSTD. The header looks pretty much the same as DCX_KRAK.
I had a quick go at adding de/compression support for it here: melak47@c7b6858

While that allowed me to open and save the new regulation bin,
the game crashes when trying to load it.
I've tried using different compression levels, and turning some optional Zstd parameters on and off (storing a checksum, for example), but no luck.

@sarkhav
Copy link
Author

sarkhav commented Jun 22, 2024

Just a quick heads up to anyone wanting to edit regulation.bin for their own personal mods, check out the ?ServerName? Discord (modding discord) and check the Tools and Resources section, Smithbox was updated to allow reading and saving.

https://discord.gg/GDkuryY2

@Philiquaz
Copy link
Collaborator

Thank you for the efforts, melak.
This is similar to what's being getting done on ?servername? (with varying zstd libs), though the issue of recompression is something we also ran into. Recompressing with existing formats, the game seems to be holding up. But I'm cautious on rushing something out without investigation, or blindly updating numbers so that things look like they work.

@Riskyyu
Copy link

Riskyyu commented Jun 27, 2024

Got Issue today 27/06/24
Untitled
Untitled2

@zhu-zisheng
Copy link

Same Issue.

DSMapStudio Version 1.11.1

Unknown DCX format.

at SoulsFormats.DCX.Decompress(BinaryReaderEx br, Type& type) in ./src/Andre/SoulsFormats/SoulsFormats/Formats/DCX.cs:line 159
at SoulsFormats.SFUtil.GetDecompressedBR(BinaryReaderEx br, Type& compression) in ./src/Andre/SoulsFormats/SoulsFormats/Util/SFUtil.cs:line 212
at SoulsFormats.MountedSoulsFile1.Read(Memory1 bytes) in ./src/Andre/SoulsFormats/SoulsFormats/Util/MountedSoulsFile.cs:line 28
at SoulsFormats.SFUtil.DecryptERRegulation(String path) in ./src/Andre/SoulsFormats/SoulsFormats/Util/SFUtil.cs:line 531
at StudioCore.ParamEditor.ParamBank.LoadParamsERFromFile(String path, Boolean encrypted) in ./src/StudioCore/ParamEditor/ParamBank.cs:line 952
at StudioCore.ParamEditor.ParamBank.LoadParamsER(Boolean partial) in ./src/StudioCore/ParamEditor/ParamBank.cs:line 878
at StudioCore.ParamEditor.ParamBank.<>c__DisplayClass73_0.b__0() in ./src/StudioCore/ParamEditor/ParamBank.cs:line 1112
at StudioCore.Editor.TaskManager.LiveTask.b__15_0() in ./src/StudioCore/Editor/TaskManager.cs:line 183
at System.Threading.Tasks.Task.InnerInvoke()
at System.Threading.Tasks.Task.<>c.<.cctor>b__281_0(Object obj)
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object)
--- End of stack trace from previous location ---
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&, Thread )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants