Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get other useful bits from the OR into the proseco ACACatalogTable? #262

Open
jeanconn opened this issue Feb 6, 2019 · 5 comments
Open
Labels
Matlab Primarily a Matlab tools issue

Comments

@jeanconn
Copy link
Contributor

jeanconn commented Feb 6, 2019

I'd be a fan of pushing for the API change on both sides to get the other good bits from the OR and schedule in there:

  1. a proper obsid (already discussed) [DONE]
  2. observation duration or tstop
  3. target offsets (code supports but not being passed by MATLAB) (See Provide target offset to proseco or sparkles sparkles#141) for more details.
    4.presence of monitor window and/or monitor window target coords [DONE]
  4. rad zone indicator (LOW PRIORITY)

2 and 3 would help for nailing down attitudes and allowed rolls for aca_preview even if small effect. 4 would be great while we're in there to help with future checks.

@taldcroft
Copy link
Member

cc: @jskrist

@taldcroft taldcroft added the Matlab Primarily a Matlab tools issue label Feb 6, 2019
@taldcroft taldcroft modified the milestone: 4.4 Feb 6, 2019
@taldcroft
Copy link
Member

Took this off the 4.4 list, not realistic for this release.

@jeanconn
Copy link
Contributor Author

jeanconn commented Mar 7, 2019

Per discussion at the 7-Mar-2019 matlab meeting, we should also pass a parameter to indicate if an observation is in the rad zone (with the thought being that non-radzone-ERs don't need 3 bright stars etc).

@jeanconn
Copy link
Contributor Author

And would it be possible to pass the allowed roll range?

@jskrist
Copy link
Member

jskrist commented Apr 11, 2019

I'm knee-deep in infrastructure changes, but I will look into this (likely during the testing phase for the next MATLAB Tools release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Matlab Primarily a Matlab tools issue
Projects
None yet
Development

No branches or pull requests

3 participants