Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coretasks: .blocks hostmask -> .blocks host #2344

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Conversation

dgw
Copy link
Member

@dgw dgw commented Aug 24, 2022

Description

Tin. Simple subcommand rename w/variables changed to match.

These are not, and AFAICT never have been, actual hostmasks. Having the subcommand name and code variables refer to them as (host)masks has been a point of confusion for, literally, years.

This is just the first step toward making the ignore/block system work more intuitively, but you know what they say about journeys of a thousand miles…

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches
    • Successfully verified listing "host" blocks, adding one (and made sure it actually ignored my test user), and then removing it.

Notes

For full context, thought processes, tentative future plans, and so on: See #1355.

That covers a lot of ground, and most of it is rightly left for the next release (again) so we can try to ship 8.0 this year. But this is a simple patch that makes room for some of those improvements, and didn't take much work to write. Hopefully it won't take much work to review, either. 😁

IMPORTANT

Assuming this is merged, https://sopel.chat/usage/ignoring-people/ needs an update for when 8.0 goes live.

These are not, and AFAICT never have been, actual host*masks*. Having
the subcommand name and code variables refer to them as (host)masks has
been a point of confusion for, literally, years.

This is just the first step toward making the ignore/block system work
more intuitively, but you know what they say about journeys of a
thousand miles...

For full context, thought processes, tentative future plans, and so on:
See #1355.
@dgw dgw added Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Aug 24, 2022
@dgw dgw added this to the 8.0.0 milestone Aug 24, 2022
@dgw dgw requested a review from a team August 24, 2022 01:35
@dgw dgw mentioned this pull request Aug 24, 2022
7 tasks
@dgw dgw merged commit 8453be4 into master Aug 27, 2022
@dgw dgw deleted the blocks-hostmask-rename branch August 27, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Stuff that probably should be mentioned in a migration guide Documentation Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants