Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check usage of jwt-cpp in Conan and CMake #369

Open
jonathan-r-thorpe opened this issue Feb 8, 2024 · 2 comments
Open

Check usage of jwt-cpp in Conan and CMake #369

jonathan-r-thorpe opened this issue Feb 8, 2024 · 2 comments

Comments

@jonathan-r-thorpe
Copy link
Contributor

Warnings on Windows 2022 builds:
'return': conversion from '__int64' to 'uint32_t', possible loss of data
https://github.com/sony/nmos-cpp/actions/runs/7818489184/job/21331360782#step:21:96
@jonathan-r-thorpe
Copy link
Contributor Author

Also Windows 2019

@garethsb
Copy link
Contributor

garethsb commented Feb 20, 2024 •
edited
Loading

Warning fixed by Thalhammer/jwt-cpp@364a557 in upstream master but not included in a release yet.

Other thing to check is whether jwt-cpp should be represented by add_library(INTERFACE) since it is header-only. For reference, see https://github.com/Thalhammer/jwt-cpp/blob/364a5572f4b46bb9f4304cb1c92acec8ddb2c620/CMakeLists.txt#L91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garethsb @jonathan-r-thorpe