Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency bumps #290

Closed
garethsb opened this issue Nov 2, 2022 · 2 comments
Closed

Dependency bumps #290

garethsb opened this issue Nov 2, 2022 · 2 comments

Comments

@garethsb
Copy link
Contributor

garethsb commented Nov 2, 2022

In order to spot incompatibilities early, we have generally tried to keep the OSS master branch close to latest versions of build dependencies.

Right now, there are quite a few things we could try bumping...

In nmos-cpp GitHub Actions workflow

  • lukka/get-cmake v3.24.2
  • lukka/run-cmake v10 (if we want to adopt cmake presets...)
  • actions/setup-python v4 (v4.3.0)

In Development/conanfile.txt

  • openssl 1.1.1s
  • boost 1.80.0

In Development/cmake/NmosCppConan.cmake

  • CONAN_VERSION_MIN 1.50.0
  • CONAN_VERSION_CUR 1.53.0

In Development/cmake/NmosCppDependencies.cmake

  • BOOST_VERSION_CUR 1.80.0

In Development/third_party/nlohmann

  • json.hpp 3.11.2

In Documents/Dependencies.md

  • cmake 3.24.2
  • conan 1.53.0
  • boost 1.80.0 (quite a few places)
  • openssl 1.1.1s

I suggest we leave Catch as the really old v1.10.0 for now since that's just a test dependency.

I suggest we remove Sandbox/conanfile.py.

In nmos-cpp recipe on Conan Center

  • required_conan_version >=1.47 or >=1.50 (maybe??)
  • openssl 1.1.1s
  • boost 1.80.0
  • cmake 3.24.2

But before updating that recipe we need...

In json-schema-validator on Conan Center:

  • nlohmann_json 3.11.2

In websocketpp recipe:

  • boost 1.80.0
  • openssl 1.1.1s
  • zlib 1.2.13
  • (standalone) asio 1.24.0 (maybe??)

In cpprestsdk recipe:

  • boost 1.80.0
  • openssl 1.1.1s
  • zlib 1.2.13
@garethsb
Copy link
Contributor Author

garethsb commented Nov 2, 2022

@lo-simon I created PRs for:

but they're all failing the Conan 2.0 migration linter checks, so need some help with that...

@garethsb
Copy link
Contributor Author

All mentioned version ups were included in #291 apart from lukka/run-cmake which is tracked in #284.

Conan recipes for json-schema-validator, websocketpp, and cpprestsdk (after a couple of follow-up conan-center-index PRs and #297, #299 to work around resulting issues with these and the recently changed avahi recipe) are now migrated to v2. I've got a PR in progress for the conan-center-index nmos-cpp recipe, currently based off tip of master, so cci.20221116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant