i32::max means end too

sonos · Sep 21, 2023 · c11c74f · c11c74f
1 parent 3aa4747
commit c11c74f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/core/src/ops/array/strided_slice.rs b/core/src/ops/array/strided_slice.rs
@@ -62,7 +62,7 @@ impl StridedSlice {
             None
         } else if end.datum_type() == i64::datum_type() {
             let end = *end.as_slice::<i64>()?.get(ix).unwrap();
-            if end == std::i64::MAX || end == std::i64::MIN || end == std::i64::MIN + 1 {
+            if end == std::i64::MAX || end == std::i64::MIN || end == std::i64::MIN + 1 || end == std::i32::MAX as _ {
                 None
             } else {
                 Some(end.to_dim())

diff --git a/hir/src/ops/array/strided_slice.rs b/hir/src/ops/array/strided_slice.rs
@@ -72,6 +72,7 @@ impl InferenceRulesOp for StridedSlice {
                 for (ix, axis) in axes.into_iter().enumerate() {
                     let preped =
                         self.prepare_one_dim(ix, &input_shape[axis], begin, end, &strides)?;
+                    dbg!(&preped);
                     output_shape[axis] = preped.soft_len()?;
                     if preped.shrink {
                         shrink.push(axis);