Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: missing favicons #238

Open
erlefloch opened this issue Feb 16, 2023 · 12 comments
Open

Bug: missing favicons #238

erlefloch opened this issue Feb 16, 2023 · 12 comments

Comments

@erlefloch
Copy link

It would be great to be able to choose the tab icon manually. This would be useful for example for Slack, which doesn't display any icon near the tab title:
image

@victorodg
Copy link

Cool, I've been missing that too.
I'm gonna try to do it. Never contributed to a github repo ever. It'll be my first one

@sonnyp
Copy link
Owner

sonnyp commented Mar 9, 2023

I don't want custom tab icons for now.

Let's solve the problem of Tangram not picking up Slack favicon instead.

@sonnyp
Copy link
Owner

sonnyp commented Mar 9, 2023

To clarify: tabs are taking too much space, I might remove them soon in favor of https://floss.social/@sonny/109672793649336496

until then it's best not to look into this

@victorodg
Copy link

Oh but I really like the spacing for the tabs :( could we make it customizable?

@sonnyp
Copy link
Owner

sonnyp commented Mar 9, 2023

Why not 👍

@victorodg
Copy link

Here I have GitHub not displaying the icon too. Kinda bugs me. Could I do something about it?

@sonnyp
Copy link
Owner

sonnyp commented Mar 9, 2023

You'll have to find out where it's failing - it's probably a small thing since it works fine in Epiphany / GNOME Web

function connectFavicon() {

@victorodg
Copy link

You'll have to find out where it's failing - it's probably a small thing since it works fine in Epiphany / GNOME Web

function connectFavicon() {

Cool, I'll try

@erlefloch erlefloch changed the title Feature request: choose tab icon manually Bug: missing favicons Mar 9, 2023
@erlefloch
Copy link
Author

@sonnyp & @victorodg thank you very much ! I've updated the title of the issue to match the discussion.

@erlefloch
Copy link
Author

Epiphany / GNOME web on browser tab:

  • github favicon ✗
  • slack favicon ✓

Epiphany / GNOME web on PWA:

  • github favicon ✓
  • slack favicon ✗

image
image
image

🙃

@sonnyp
Copy link
Owner

sonnyp commented Mar 9, 2023

you have to use GNOME Web 44, not 43

@erlefloch
Copy link
Author

erlefloch commented Mar 9, 2023

Thanks for the hint.
Using Epiphany Technology Preview (flatpak, version 44~rc) :

browser tab:

  • github favicon still ✗
  • slack favicon still ✓

PWA:

  • PWA installation did not work on Epiphany Technology Preview (tried a few times).

EDIT: tried again with Epiphany v45. The Slack favicon is now correctly displayed both on browser tab and webapp, whereas the GitHub favicon fails both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants