Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVST Feature commit #3316

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

divyachandralekha
Copy link

Added new stpmgr for STP config handling
Added changes in orchagent for STP programming via SAI APIs

What I did
Added new stpmgr under cfgmgr for handling STP config notifications
Added STP changes in stporch component to handle STP operations (STP Instance creation/deletion, STP Port Add/Update/Del to STP instance) via SAI

Why I did it
PVST Feature support

@divyachandralekha divyachandralekha changed the title Pvst co pr PVST Feature enable Oct 4, 2024
@divyachandralekha divyachandralekha changed the title PVST Feature enable PVST Feature commit Oct 4, 2024
@divyachandralekha
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@muhammadalihussnain muhammadalihussnain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Please re trigger pipelines to pass the checks

@divyachandralekha
Copy link
Author

stp repo should be merged to resolve the compilation errors here.

@divyachandralekha
Copy link
Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Pull request contains merge conflicts.

@divyachandralekha
Copy link
Author

/AzurePipelines run Azure.sonic-swss

Copy link

Commenter does not have sufficient privileges for PR 3316 in repo sonic-net/sonic-swss

@divyachandralekha
Copy link
Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@divyachandralekha
Copy link
Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@divyachandralekha
Copy link
Author

@ridahanif96 @wajahatrazi , please help review and signoff for 202411

Copy link

@ridahanif96 ridahanif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@wajahatrazi wajahatrazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covers the functionality. Can proceed with merge. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants