-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PVST Feature commit #3316
base: master
Are you sure you want to change the base?
PVST Feature commit #3316
Conversation
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Please re trigger pipelines to pass the checks
stp repo should be merged to resolve the compilation errors here. |
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Pull request contains merge conflicts. |
/AzurePipelines run Azure.sonic-swss |
Commenter does not have sufficient privileges for PR 3316 in repo sonic-net/sonic-swss |
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
@ridahanif96 @wajahatrazi , please help review and signoff for 202411 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Covers the functionality. Can proceed with merge. Thanks
Added new stpmgr for STP config handling
Added changes in orchagent for STP programming via SAI APIs
What I did
Added new stpmgr under cfgmgr for handling STP config notifications
Added STP changes in stporch component to handle STP operations (STP Instance creation/deletion, STP Port Add/Update/Del to STP instance) via SAI
Why I did it
PVST Feature support