Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbus timeout to 10 minutes #326

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Nov 12, 2024

Why I did it

We found that GCU takes about 10 minutes to update ACL rules

How I did it

Update dbus timeout to 10 minutes so that we can use GNMI to update ACL rules.

How to verify it

Run GNMI unit test and end to end test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copy link

@wen587 wen587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a global value so that everytime we just modify the single variable?

@ganglyu ganglyu merged commit 883d617 into sonic-net:master Nov 12, 2024
5 checks passed
ganglyu added a commit that referenced this pull request Nov 12, 2024
Why I did it
We found that GCU takes about 10 minutes to update ACL rules
Backport #326

How I did it
Update dbus timeout to 10 minutes so that we can use GNMI to update ACL rules.

How to verify it
Run GNMI unit test and end to end test
ganglyu added a commit that referenced this pull request Nov 12, 2024
Why I did it
We found that GCU takes about 10 minutes to update ACL rules
Backport #326

How I did it
Update dbus timeout to 10 minutes so that we can use GNMI to update ACL rules.

How to verify it
Run GNMI unit test and end to end test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants