Fix random build failures due to syntax error in sonic_internal.proto #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Fixed the syntax error in sonic_internal.proto file (introduced by commit 58a7b20). It appears that sonic_internal.pb.go was manually updated earlier; hence this syntax error went unnoticed. 2) Removed the makefile target to compile gnmi_server test binary. It is not used now as 'make check_gotest' runs the go tests directly on source files. Prevents unnecessary trigger of proto file compilations
sachinholla
force-pushed
the
proto_syntax_err
branch
from
34eac2e to
b8a2418
Compare
6 tasks
zbud-msft
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
PR #139 introduced a syntax error in sonic_internal.proto file. Looks like sonic_internal.pb.go was manually updated and not re-generated from the proto file. Hence the syntax error went unnoticed.
Now sonic_internal.pb.go re-generation is getting triggered randomly in some clones during docker build causing build failure. This build includes a make target that compiles gotest binary for gnmi_server package. All go files are prerequisites for this target. This triggers sonic_internal.pb.go target if sonic_internal.proto got a higher timestamp than sonic_internal.pb.go during git clone. Hence the random failure.
This gotest binary is never used now. Pipeline builds run the go tests directly on source packages. Hence we can remove this makefile target.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)