Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next version #161

Open
14 of 15 tasks
sondr3 opened this issue May 3, 2017 · 8 comments
Open
14 of 15 tasks

Next version #161

sondr3 opened this issue May 3, 2017 · 8 comments

Comments

@sondr3
Copy link
Owner

sondr3 commented May 3, 2017

TODO BEFORE RELEASE

  • Change Codecov and Travis CI badges to point back to master again.

Old text

New maintainer

I'm looking for someone willing to take over the responsibility of maintaining this generator, I don't use this anymore, haven't kept up with the Node community but I'd love to see this generator live on in the hands of someone willing to continue the development of it.

Next version

First of all, some things are needed purely for maintenance:

  • Convert to Yeoman v1
  • Move testing to Jest
  • Move linting to Prettier
  • Rewrite documentation/README
    • Mention Yarn over using NPM

And then we have some issues/ideas that tie directly into sondr3/generator-statisk and the next release of it, namely:

  • Consider removing the uploading options as they are a major hassle and not really what the scope of this package is about, maybe refactor them out into their own package?
  • Move to webpack from Gulp, the pace of development for it is glacial and it looks like everyone and their dog is moving to webpack
    • BrowserSync and webpack?
    • Calling out to Jekyll from webpack?
    • Moving to NPM scripts
  • Merge the gulp subgenerator from generator-statisk back into this generator again.

There are also some other things to update, such as:

  • Update the theme, layout files and such to the latest version of Jekyll
  • Look into whether themes from gems can be used together with this generator (doubtful from my initial look)

Look into using RunJS as an alternative to Gulp:

All together, and especially with the potential move to webpack, it might be that a major version bump brings us up to version 2 and more or less foregoes version 1. If no more issues pop up and I fix the latest issues that I know about I might just push a v1 to NPM and set my sights on the next version.

@sondr3
Copy link
Owner Author

sondr3 commented Feb 16, 2018

I've created some notes on the project board if you want to take a look @farleykreynolds.

@sondr3 sondr3 modified the milestone: 2.0 Feb 16, 2018
@CesarDenis
Copy link

@sondr3 are you still in need of help? I love your generator, I use it for several projects and wanted to upgrade them to webpack.

I'm starting to learn webpack, I'm available for help.

@sondr3
Copy link
Owner Author

sondr3 commented Apr 12, 2018

Sure, I'd love help! Feel free to ask away either here on GitHub or in the email on my profile if you want to :)

@CesarDenis
Copy link

@sondr3 what are your ideas for the next steps?
What I've seen, it's just the webpack. That's it?

@sondr3
Copy link
Owner Author

sondr3 commented Apr 13, 2018

For the most part, yes, I've updated the generator itself to the latest version (at the time at least) of Yeoman and testing tools etc, but I haven't kept up with both Jekyll or the larger front end ecosystem on NPM at all.

There's also some low-hanging fruit that I'm not sure how to tackle from the top of my head:

  • The way we currently inject CSS and JS into the Jekyll templates is really brittle and prone to errors and failures that can come from a ton of different sources. I'd like for this to either be handled properly or just have a mention that adding more CSS or JS files means you'll have to manually add them. The problem with that is that previously we gave all the files a hash so that you don't end up with old versions of CSS in your cache when you've updated your site, having to manually add URLs would break this.
  • I've thought about maybe moving from Gulp to just regular NPM scripts, but that looks to be a bit of a hassle.
  • Jekyll now has a built-in livereload that really fast for updating files and such.
  • I've always wanted to be able to actually install the generator and run some commands in the test environment to make sure that things break when you're updating but not actually using it.

I've created a few issues both here on the issue board and some notes on the project board too if you want to have a look. But the biggest thing on the menu right now is getting Jekyll up to speed and implementing Webpack for bundling and optimizing of assets.

@CesarDenis
Copy link

@sondr3 I did a test with webpack and jekyll and put it in my repository.

Need to improve the webpack, but see if that's what you imagined.

@sondr3
Copy link
Owner Author

sondr3 commented May 11, 2018

@CesarDenis Sorry, I thought I responded to you but seems like I either forgot to or didn't actually submit it. But yes! That looks really great, pretty much exactly the kind of stuff that I wanted to do. If you want to contribute something like this to the overhaul branch I'd greatly appreciate it! Again, sorry for the slow response 😃

@CesarDenis
Copy link

@sondr3 no problem. I will improve the webpack as soon as I finish doing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants