Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontUnit does not work #26

Open
pikkupullo opened this issue Feb 11, 2019 · 2 comments
Open

fontUnit does not work #26

pikkupullo opened this issue Feb 11, 2019 · 2 comments
Labels

Comments

@pikkupullo
Copy link

pikkupullo commented Feb 11, 2019

Tried to use this, and noticed that fontUnit does not work. When adding [fontUnit], the resizing gets broken. If only using for example [maxFontSize] without [fontUnit] it works with the default value (px). Would like to use vh with this one. Otherwise nice work!

I am still using ng5 in one project, hadn't had the time to try ng6, because my guess is that a bunch of plugins will get broken.

@sollenne
Copy link
Owner

Is this still an issue @pikkupullo ? I'm doing some work to it. Have you thought about creating a PR?

@sollenne sollenne added the bug label May 31, 2019
@pikkupullo
Copy link
Author

@sollenne Yes, a minor problem but still exists. I have a bootstrap carousel in mobile in which might contain long descriptions, and those go out of screen without resizing. Breaking those into multiple lines is not really an option.

Haven't thought about putting my fingers in this one currently :D Might do it if required, but currently way too many things to do, so it might take a while.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants