Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typecheck command for typescript templates #70

Open
carcinocron opened this issue Oct 23, 2022 · 1 comment
Open

typecheck command for typescript templates #70

carcinocron opened this issue Oct 23, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@carcinocron
Copy link

carcinocron commented Oct 23, 2022

Vue 3 has in it's default package.json:

{
  "scripts": {
    "typecheck": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"
  }
}

I noticed that this command seems to work for the current solidjs typescript templates:

tsc -p ./tsconfig.json

is that the optimal command for typechecking a solidjs app? We should add it for all typescript templates.

In Vue 3, yarn run dev also outputs typechecking information, is it possible to add that to the solidjs typescript templates?

@amoutonbrady
Copy link
Member

Hey, thanks for filling out an issue 🙏🏻

I'm not entirely sure if this is the best way to typecheck a Solid project.
For the record I've written a project with more than 12k lines of Solid and almost never had the need to it (although it probably bit me once or twice in CI).

I'm not against adding an extra typecheck script if that can help some people get things running but I won't have the time to see how and if we should try to parallelize type checking in dev.

Would you be open for a PR ? :)

@amoutonbrady amoutonbrady added the good first issue Good for newcomers label Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants