Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: syntax errors in ./app.tsx causes uncaught 500 error #1648

Open
2 tasks done
bigmistqke opened this issue Oct 6, 2024 · 1 comment
Open
2 tasks done

[Bug?]: syntax errors in ./app.tsx causes uncaught 500 error #1648

bigmistqke opened this issue Oct 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bigmistqke
Copy link

bigmistqke commented Oct 6, 2024

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

When editing app.tsx the website will 500 when the app i in an incorrect state. The dev-overlay is visible for a fraction of a second and then the default browser display is shown. The app is then not being able to get recovered with hmr.

Screen.Recording.2024-10-06.at.04.45.41.mov

When editing a file that app.tsx imports (and renders), the error does not occur:

Screen.Recording.2024-10-06.at.04.47.21.mov

It was slightly different behavior in the context of where I found out about the bug. I am making a sveltelab thingy for the hackathon, a repl powered by stackblitz' webcontainers. There some imports did cause similar 500s.

solidlab2.mp4

routes that are currently rendered can also be edited without 500, it's only app.tsx

basic.mp4

Expected behavior 🤔

To be able to write invalid code without the app getting in to an unrecoverable 500-error.

Steps to reproduce 🕹

Steps:

  1. clone the bare solid start example
  2. pnpm install && pnpm dev
  3. edit src/app.tsx so it is invalid javascript and save
  4. see that page 500s without dev-overlay
  5. edit src/app.tsx so it is valid again
  6. see that it does not reload

Context 🔦

No response

Your environment 🌎

No response

@bigmistqke bigmistqke added the bug Something isn't working label Oct 6, 2024
@ryansolid
Copy link
Member

Hmm.. trying to think about who to get to look at this one. HMR behavior here could be related to Vinxi (@nksaraf) or it could be related to solid refresh or the overlay (@lxsmnsyc). Maybe either of them would have a better idea of how this should be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants