You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When editing app.tsx the website will 500 when the app i in an incorrect state. The dev-overlay is visible for a fraction of a second and then the default browser display is shown. The app is then not being able to get recovered with hmr.
Screen.Recording.2024-10-06.at.04.45.41.mov
When editing a file that app.tsx imports (and renders), the error does not occur:
Screen.Recording.2024-10-06.at.04.47.21.mov
It was slightly different behavior in the context of where I found out about the bug. I am making a sveltelab thingy for the hackathon, a repl powered by stackblitz' webcontainers. There some imports did cause similar 500s.
solidlab2.mp4
routes that are currently rendered can also be edited without 500, it's only app.tsx
basic.mp4
Expected behavior 🤔
To be able to write invalid code without the app getting in to an unrecoverable 500-error.
Steps to reproduce 🕹
Steps:
clone the bare solid start example
pnpm install && pnpm dev
edit src/app.tsx so it is invalid javascript and save
see that page 500s without dev-overlay
edit src/app.tsx so it is valid again
see that it does not reload
Context 🔦
No response
Your environment 🌎
No response
The text was updated successfully, but these errors were encountered:
Hmm.. trying to think about who to get to look at this one. HMR behavior here could be related to Vinxi (@nksaraf) or it could be related to solid refresh or the overlay (@lxsmnsyc). Maybe either of them would have a better idea of how this should be working.
Duplicates
Latest version
Current behavior 😯
When editing
app.tsx
the website will 500 when the app i in an incorrect state. The dev-overlay is visible for a fraction of a second and then the default browser display is shown. The app is then not being able to get recovered with hmr.Screen.Recording.2024-10-06.at.04.45.41.mov
When editing a file that
app.tsx
imports (and renders), the error does not occur:Screen.Recording.2024-10-06.at.04.47.21.mov
It was slightly different behavior in the context of where I found out about the bug. I am making a sveltelab thingy for the hackathon, a repl powered by stackblitz' webcontainers. There some imports did cause similar 500s.
solidlab2.mp4
routes that are currently rendered can also be edited without 500, it's only
app.tsx
basic.mp4
Expected behavior 🤔
To be able to write invalid code without the app getting in to an unrecoverable 500-error.
Steps to reproduce 🕹
Steps:
Context 🔦
No response
Your environment 🌎
No response
The text was updated successfully, but these errors were encountered: