Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta pwa #534

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix meta pwa #534

wants to merge 5 commits into from

Conversation

Brian-Pob
Copy link

Multiple improvements

  • clean up meta tags in index.html
    • removing repeated tags
    • adding correct tag attributes
    • property= instead of name= for some tags as per OG protocol
  • implement PWA functionality
    • I noticed there was an attempt to include PWA functionality before.
    • uses vite-plugin-pwa as it was already part of the dependencies
  • added images for PWA functionality
    • used the existing icons located in public/img/icons
    • does not explicitly set PWA options for Android or iOS yet
    • screenshot images were taken using Arc browser's screenshot tool
    • I can use different images if requested

@Brian-Pob
Copy link
Author

Brian-Pob commented Mar 28, 2024

Tried deploying my fork onto CF pages and Vercel and couldn't get either to work. :(
It does work when I run pnpm dev but running build reveals some errors that I don't know how to fix.

This is the error that pops up whenever build is executed

Cannot use 'in' operator to search for 'children' in undefined
file: .../solid-site-fix-meta/src/pages/Articles/state-of-solid-december-2021.mdx

Edit: Fixed this in 86b3d51

@Brian-Pob Brian-Pob marked this pull request as ready for review April 2, 2024 08:00
@Brian-Pob
Copy link
Author

CFP Preview link https://4748970c.solid-site-fix-meta.pages.dev/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant