Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old "hashed" (aka lz-string-ed) Playground links are broken #147

Open
AlexErrant opened this issue Jun 18, 2023 · 1 comment
Open

Old "hashed" (aka lz-string-ed) Playground links are broken #147

AlexErrant opened this issue Jun 18, 2023 · 1 comment

Comments

@AlexErrant
Copy link

AlexErrant commented Jun 18, 2023

I found a playground link in this issue:

https://playground.solidjs.com/?version=1.3.5#NobwRAdghgtgpmAXGGUCWEwBowBcCeADgsrgM4Ae2YZA9gK4BOAxiWGjIbY7gAQi9GcCABM4jXgF9eAM0a0YvADo1aAGzQiAtACsyAegDucAEYqA3EogcuPfr2ZCouOAGU0Ac2hqsvWhABhNTgoCHpCKVl5RRU6DW09CysrGXoIZlw0f14AhggXRgAKAEp+K14HfzI+YGY83F8yOFxctNwAXV4AXgcnF3cvKDVCgAZiywgK8t5gvk1u3ibcAEl88QA3IcKS7oA+RebW-MK6tp2Aal4ARmLfK5GH8en-IJCwwm3Srv3mYKhGVYFTbDTTFJ4QaZCXBMSaFaYVAA8JnouFw2QIxC6KmRqP8Kj8gQ0zAA1l0QLU9pUIHE4AA6NS0DwnW6VM7FdqSXbwipUmn0xk7ZhMIT5VmiwogU7HYqSYrchH6HFoiBcya8cGSZIQEViIo7b68BFHAq8fS7XwiWhC+D5WkeZoAUWCNtwACF8MsRHCwFBCIQVGCJmBJO0gA

Opening the above link in Chrome incognito, Chrome Guest mode, and Chrome Canary Guest mode all yield the default counter; not whatever the author customized.

However, when I clone and run the repo locally, the following link works (in both dev and preview):

http://localhost:4173/?version=1.3.5#NobwRAdghgtgpmAXGGUCWEwBowBcCeADgsrgM4Ae2YZA9gK4BOAxiWGjIbY7gAQi9GcCABM4jXgF9eAM0a0YvADo1aAGzQiAtACsyAegDucAEYqA3EogcuPfr2ZCouOAGU0Ac2hqsvWhABhNTgoCHpCKVl5RRU6DW09CysrGXoIZlw0f14AhggXRgAKAEp+K14HfzI+YGY83F8yOFxctNwAXV4AXgcnF3cvKDVCgAZiywgK8t5gvk1u3ibcAEl88QA3IcKS7oA+RebW-MK6tp2Aal4ARmLfK5GH8en-IJCwwm3Srv3mYKhGVYFTbDTTFJ4QaZCXBMSaFaYVAA8JnouFw2QIxC6KmRqP8Kj8gQ0zAA1l0QLU9pUIHE4AA6NS0DwnW6VM7FdqSXbwipUmn0xk7ZhMIT5VmiwogU7HYqSYrchH6HFoiBcya8cGSZIQEViIo7b68BFHAq8fS7XwiWhC+D5WkeZoAUWCNtwACF8MsRHCwFBCIQVGCJmBJO0gA

(In particular, the onClick looks like onClick={[c => console.log(c), count()]})

I think there's an old deploy on https://playground.solidjs.com that's broken...? I don't see any Github Actions, so I don't know anything :D

@milomg
Copy link
Member

milomg commented Apr 11, 2024

We currently deploy a series of patches on top of main (https://github.com/solidjs/solid-playground/tree/legacy), looks like one of them must've broken this feature...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants