Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content]: Document Single-Flight Mutations + failures #777

Open
davedbase opened this issue Jun 12, 2024 · 1 comment
Open

[Content]: Document Single-Flight Mutations + failures #777

davedbase opened this issue Jun 12, 2024 · 1 comment
Labels
help wanted Looking for assistance on this issue solid Related to core Solid

Comments

@davedbase
Copy link
Member

📚 Subject area/topic

SolidStart Single-Flight Mutations

📋 Page(s) affected (or suggested, for new content)

New section rquired

📋 Description of content that is out-of-date or incorrect

It would be useful and important to add documentation for Single-Flight Mutations. This doesn't seem to be documented anywhere. It should include:

  • A description of what it is and how to use it
  • An Eraser chart of how mutations actually work (look at SolidStart 1.0 release announcement for a sample)
  • How to handle failures

Regarding the last point, this came up in a conversation recently in Start Team chat:

From what I understand, if the mutation (action) fails then you handle that as normal, whether by catching the error or using submission state. If one of the data fetches fail then that'll be reflected by whatever createAsync is consuming the data fetch, since SFM just inserts the promise returned by cache on the server into the cache on the client

What's also confusing is the fact that there's an Action section in the router docs however it's unclear how it's related to SFMs. It's slightly confusing that actions are described in router outside of Start as well.

I'm wondering if it's necessary to create a section describing mutations and ensure that users know how to find their way to actions? Perhaps this is a separate issue entirely? I don't see this requested/discussed in other topics so I'll pose it here for now.

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

@davedbase davedbase added improve documentation pending review Awaiting review by team members. labels Jun 12, 2024
@LadyBluenotes LadyBluenotes removed their assignment Jul 18, 2024
@LadyBluenotes LadyBluenotes added help wanted Looking for assistance on this issue and removed pending review Awaiting review by team members. labels Jul 18, 2024
@LadyBluenotes LadyBluenotes added solid Related to core Solid and removed improve documentation labels Sep 26, 2024
@brenelz
Copy link
Collaborator

brenelz commented Nov 24, 2024

I believe this was explained a bit in the submission for the data guide from the hackathon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for assistance on this issue solid Related to core Solid
Projects
None yet
Development

No branches or pull requests

3 participants