Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Move i18n to @solid-primitives #5

Open
davedbase opened this issue Apr 23, 2022 · 1 comment
Open

Suggestion: Move i18n to @solid-primitives #5

davedbase opened this issue Apr 23, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@davedbase
Copy link
Member

davedbase commented Apr 23, 2022 •
edited
Loading

I think the locale directive would be extremely useful if it were centralized? If this is the only primitive in the React Aria i18n lib then I'm thinking we should just move this over. I can even handle it + add tests if you'd like. It's a pretty simple primitive to begin with so I see no reason not to unless @fabien-ml has objections.
@davedbase davedbase added the enhancement New feature or request label Apr 23, 2022
@fabien-ml
Copy link
Member

It's not the whole react-aria i18n package yet. I've just ported the pieces needed for the radio package. Other pieces will be ported when I find them in other packages so I know why I'm porting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davedbase @fabien-ml