Add tailing functionality #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grepory
requested changes
Jul 8, 2024
grepory
approved these changes
Jul 9, 2024
grepory
approved these changes
Jul 9, 2024
markdascher
reviewed
Jul 12, 2024
Comment on lines
+199
to
+201
| if logs.NextPage == "" { | ||
| break | ||
| } |
There was a problem hiding this comment.
Moving this up here isn't necessarily safe. If there are events sent back in the last page, this will drop them. (The API might not do this currently, but it probably will in the future.)
I think we probably want this to go back to its original spot, and then the time.Sleep can go at the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--followflaggroupflag usage