-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setTransactionMessageFeePayer()
does not delete signer if one is present.
#2899
Labels
bug
Something isn't working
Comments
We could fix this once and for all by making export interface ITransactionMessageWithFeePayer<TAddress extends string = string> {
readonly feePayer: Readonly<{__type: 'address', address: Address<TAddress>}>;
}
export interface ITransactionMessageWithFeePayerSigner<
TAddress extends string = string,
TSigner extends TransactionSigner<TAddress> = TransactionSigner<TAddress>,
> {
readonly feePayer: Readonly<{__type: 'signer'}> & TSigner;
} That would be a whole bunch of surgery, but we'd end up with something that always had address on it as we have now, no matter if it was a signer or not, and the decision of whether to overwrite it could involve checking that the two |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Presume that you have a
TransactionMessage
with afeePayerSigner
. If the fee payer address changes,setTransactionMessageFeePayer()
won't blank out the pre-existingfeePayerSigner
.Description of bug
This may cause problems if I go from:
The Phantom
feePayerSigner
will still be on the message.The text was updated successfully, but these errors were encountered: