Add rest consumers stats #80
Conversation
semp/metricDesc.go
Outdated
| "http_post_response_messages_received_successful": NewSemDesc("rdp_http_post_response_messages_received_successful", NoSempV2Ready, "The numer of response messages received successfully.", variableLabelsRestConsumer), | ||
| "http_post_response_messages_received_error": NewSemDesc("rdp_http_post_response_messages_received_error", NoSempV2Ready, "The numer of response messages received with errors", variableLabelsRestConsumer), | ||
| "http_post_request_bytes_sent": NewSemDesc("rdp_http_post_request_bytes_sent", NoSempV2Ready, "The request bytes sent.", variableLabelsRestConsumer), | ||
| "http_post_response_bytes_received": NewSemDesc("rdp_http_post_response_bytes_received", NoSempV2Ready, "The response bytes received.", variableLabelsRestConsumer), |
There was a problem hiding this comment.
rename to rdp_http_post_response_received_bytes to be prometheus complient.
There was a problem hiding this comment.
I've changed the names of the metrics to be more Prometheus compliant. Please check if it is ok. I've push the changes to my branch already. Do I need to create another pull request? Sorry, I'm new here.
semp/metricDesc.go
Outdated
| "http_post_response_messages_received": NewSemDesc("rdp_http_post_response_messages_received", NoSempV2Ready, "The numer of response messages received.", variableLabelsRestConsumer), | ||
| "http_post_response_messages_received_successful": NewSemDesc("rdp_http_post_response_messages_received_successful", NoSempV2Ready, "The numer of response messages received successfully.", variableLabelsRestConsumer), | ||
| "http_post_response_messages_received_error": NewSemDesc("rdp_http_post_response_messages_received_error", NoSempV2Ready, "The numer of response messages received with errors", variableLabelsRestConsumer), | ||
| "http_post_request_bytes_sent": NewSemDesc("rdp_http_post_request_bytes_sent", NoSempV2Ready, "The request bytes sent.", variableLabelsRestConsumer), |
There was a problem hiding this comment.
rename to rdp_http_post_request_sent_bytes to be prometheus complient.
There was a problem hiding this comment.
I've changed the names of the metrics to be more Prometheus compliant. Please check if it is ok. I've push the changes to my branch already. Do I need to create another pull request? Sorry, I'm new here.
semp/metricDesc.go
Outdated
| @@ -477,4 +478,15 @@ var MetricDesc = map[string]Descriptions{ | |||
| "connection_fast_retransmit": NewSemDesc("connection_fast_retransmit", NoSempV2Ready, "The number of TCP segments retransmitted due to the receipt of duplicate acknowledgments (‘ACKs’). See RFC 5681 for further details.", variableLabelsVpnClient), | |||
| "connection_timed_retransmit": NewSemDesc("connection_timed_retransmit", NoSempV2Ready, "The number of TCP segments re-transmitted due to timeout awaiting an ACK. See RFC 793 for further details.", variableLabelsVpnClient), | |||
| }, | |||
| "RestConsumerStats": { | |||
| "http_post_request_messages_sent": NewSemDesc("rdp_http_post_request_messages_sent", NoSempV2Ready, "The numer of request messages sent.", variableLabelsRestConsumer), | |||
There was a problem hiding this comment.
Number of what kind of requests send to where?
Please be more specific, to make help text helpfull for non solace broker seniors.
There was a problem hiding this comment.
I've make the description more clear. Please check if it is ok. thanks.
… compliant. Added more details to the description of each metric for the rest consumer stats.
|
Thank you for contributing. |
I'm adding "show message-vpn rest rest-consumer stats" to the exporter.