Fix for issue caused by reusing labels #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new labels for BridgeRemote, InterfaceHW and Redundancy Also minor fix to update error logging
|
Ready to merge, Fixes Issue #75 |
GreenRover
requested changes
Sep 11, 2024
Meaningful name for BridgeRemote metrics Remove HW specific redundancy role metric
|
Updated code for changes 3 & 4, waiting for confirmation on 1 & 2 |
|
I marked the comments on the log messages as resolved, please let me know if you disagree and I will update the code. |
GreenRover
requested changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new labels for BridgeRemote, InterfaceHW and Redundancy
Also minor fix to update error logging