Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve metrics descriptions #69

Merged
merged 4 commits into from
May 7, 2024

Conversation

GreenRover
Copy link
Collaborator

No description provided.

@GreenRover GreenRover self-assigned this Apr 19, 2024
Copy link

gitguardian bot commented Apr 19, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10447218 Triggered Generic Password 839ac1d solace_prometheus_exporter.ini View secret
10829466 Triggered Username Password 33c7314 solace_prometheus_exporter.ini View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@GreenRover GreenRover requested a review from helios57 April 19, 2024 17:03
@GreenRover GreenRover force-pushed the feature/improve_metrics_descriptions branch from ae376cb to 839ac1d Compare April 24, 2024 09:57
@GreenRover GreenRover merged commit d71b5af into master May 7, 2024
0 of 2 checks passed
@GreenRover GreenRover deleted the feature/improve_metrics_descriptions branch May 7, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants