Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold in bug fixes #34

Merged
merged 5 commits into from
May 23, 2024
Merged

Fold in bug fixes #34

merged 5 commits into from
May 23, 2024

Conversation

karacolada
Copy link
Member

Description

Fixed handling of license files:

Related issue: #30 and #31

How has this been tested?

Automated testing in GH actions, manual testing in local dev environment as described in the README.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • [z] I have read the contributor guide.
  • [z] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [z] All new and existing tests passed.

Copy link

📋 Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
. 61% 35%
config 100% 100%
controllers 86% 56%
evaluators 48% 27%
harvester 58% 48%
helper 65% 55%
models 75% 85%
Summary 63% (7720 / 12173) 55% (3306 / 6024)

Copy link

📋 Pytest Results

19 tests  ±0   19 ✅ ±0   35s ⏱️ +15s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 1778e73. ± Comparison against base commit 0aadc41.

@karacolada karacolada merged commit 03c8f24 into dev May 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant