Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for sub/super-types #183

Closed
adamw opened this issue Oct 17, 2021 · 7 comments
Closed

Tests for sub/super-types #183

adamw opened this issue Oct 17, 2021 · 7 comments
Labels
autowire

Comments

@adamw
Copy link
Member

adamw commented Oct 17, 2021

We should test if things work fine when a sub-type is provided as an instance/resource/..., while the declared dependency is of a super-type (e.g. a trait & and implementing class)
@adamw adamw added the autowire label Oct 17, 2021
@adamw adamw mentioned this issue Oct 17, 2021
Merged
@mbore
Copy link
Contributor

mbore commented Oct 18, 2021

Already solved in #175 (4b70ca2)

@adamw
Copy link
Member Author

adamw commented Oct 18, 2021

Great :) Do we have tests, though? In the commit, one test is deleted ;)

@mbore
Copy link
Contributor

mbore commented Oct 18, 2021

Oh yeah, I forgot to add it in that commit. It's here

@adamw
Copy link
Member Author

adamw commented Oct 18, 2021

I'd also add one for resources, just in case :)

@mbore
Copy link
Contributor

mbore commented Oct 21, 2021

added here

@adamw
Copy link
Member Author

adamw commented Oct 21, 2021

So this can be closed, then? :)

@mbore
Copy link
Contributor

mbore commented Oct 21, 2021

ah yep :)

@mbore mbore closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
autowire
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamw @mbore