-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encryption Attributes Cause Exception #130
Comments
I think these attributes are not supported yet, hence the exception. Maybe unsupported attributes should be silently ignored even when setting, though this might be against the SQS spec. So it would be best to add support for them. |
Has any progress been made on addressing this issue, or is there any workaround for this issue besides having to flag functionality between testing and production code when setting those attributes? |
@Drozenbo not yet, but maybe you'd like to try fixing the problem? If you'd have problems with the codebase I'll be happy to help |
First of all, thanks for contributing elasticmq! It's gonna be great to have SQS-like queues running in developer environments.
Perhaps I'm doing something wrong, but I find if I try to create a queue with encryption attributes (i.e. "KmsMasterKeyId" and/or "KmsDataKeyReusePeriodSeconds"), the attributes are silently ignored (i.e. a subsequent request to GetQueueAttribute shows neither).
Furthermore, if I try to update an existing queue with either attribute, the operation fails with InvalidAttributeNameException (see below). It was a bit difficult to debug, because nowhere does the name of the invalid attribute appear in the exception message.
I can certainly understand if message encryption is outside of elasticmq's scope. It would be nice though if it recognized these as valid attributes and preserved them as such (both on creation and update).
More broadly, it would be great if the README could specify what SQS operations/attributes are currently unsupported (or supported, whichever is easier). It's been a bit of a slog running into them piecemeal.
If you agree, I would be happy to take a whack at contributing a fix for this issue. Thanks.
The text was updated successfully, but these errors were encountered: