Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdopkg patch fails if format.coverletter = auto #181

Open
yazug opened this issue Oct 21, 2019 · 1 comment
Open

rdopkg patch fails if format.coverletter = auto #181

yazug opened this issue Oct 21, 2019 · 1 comment

Comments

@yazug
Copy link
Contributor

yazug commented Oct 21, 2019

Had an instance where a user enabled at least the following and when rdopkg patch was run it generated a bad patchset

[format]
signoff = true
coverletter = auto

all of the patches were signed (not a problem just noise) but there was a 0000-cover-letter.patch included that failed to apply and I think there was a hole in the patch set at some point but didn't reproduce any beyond this.

I think the fix for this would be to make sure git format-patch also passes in --no-cover-letter option when it makes the call.

@stephenfin
Copy link

It also fails if diff.noprefix is set to True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants