Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: make patches_base and patches_ignore independent #155

Open
yac opened this issue Mar 12, 2018 · 1 comment
Open

RFE: make patches_base and patches_ignore independent #155

yac opened this issue Mar 12, 2018 · 1 comment
Labels
enhancement

Comments

@yac
Copy link
Contributor

yac commented Mar 12, 2018

I don't even know how this emergent pattern came into existence, but patches_ignore requires patches_base.

With the power of feature tests, make sure they are independent as they should be.
@yazug
Copy link
Contributor

yazug commented Mar 12, 2018

This is an artifact of warning given if patches_ignore is used and no patches_base is present... Some of the regex for placing new magic comments tied relied on patches_base being present

@yac yac removed the next label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yac @yazug