Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mapping lib #110

Open
THenry14 opened this issue Oct 1, 2024 · 2 comments
Open

Use mapping lib #110

THenry14 opened this issue Oct 1, 2024 · 2 comments
Assignees

Comments

@THenry14
Copy link
Member

THenry14 commented Oct 1, 2024

software-mansion/cairo-annotations#4

@THenry14
Copy link
Member Author

THenry14 commented Oct 2, 2024

@ksew1
Copy link
Member

ksew1 commented Oct 14, 2024

I believe we can take the following actions:

  • Utilize trace-data from cairo-annotations. We should deprecate trace-data in the profiler and include a message indicating that it will be removed in the next version.
  • Use map_pcs_to_sierra_statement_ids in some parts of the code here: function_trace_builder.rs.
  • Replace the existing implementation with cairo-annotations's ProfilerAnnotations instead of using the current approach in sierra_loader.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants